Skip to content

treewide: Fix malformed input hashes#536649

Open
KAction wants to merge 1 commit into
NixOS:masterfrom
KAction:push-qrslumrxzrkq
Open

treewide: Fix malformed input hashes#536649
KAction wants to merge 1 commit into
NixOS:masterfrom
KAction:push-qrslumrxzrkq

Conversation

@KAction

@KAction KAction commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Nixcpp implementation of base64 decoder ignores everything that comes after the first "=" symbol. Clean up the existing nixpkgs code so the decoder can be made strict one day.

https://github.com/NixOS/nix/blob/master/src/libutil/base-n.cc#L94

Things done

@KAction
treewide: Fix malformed input hashes
f3e8af2 
Nixcpp implementation of base64 decoder ignores everything that comes
after the first "=" symbol. Clean up the existing nixcpp code so the
decoder can be made strict one day.

https://github.com/NixOS/nix/blob/master/src/libutil/base-n.cc#L94
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: games Gaming on NixOS labels Jun 29, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 29, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 29, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavHau DavHau Awaiting requested review from DavHau
@flexiondotorg flexiondotorg Awaiting requested review from flexiondotorg
@heywoodlh heywoodlh Awaiting requested review from heywoodlh
@MayNiklas MayNiklas Awaiting requested review from MayNiklas
@msteen msteen Awaiting requested review from msteen
@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid
3 more reviewers
@r3dl3g r3dl3g r3dl3g approved these changes
@liamthexpl0rer liamthexpl0rer liamthexpl0rer approved these changes
@GraysonTinker GraysonTinker GraysonTinker approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: games Gaming on NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KAction @r3dl3g @liamthexpl0rer @GraysonTinker