omnissa-horizon-client: fix blank desktop tile labels#536800
Open
carlzulauf wants to merge 1 commit into
Open
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
Prior to this change, the omnissa-horizon-client renders server labels as empty boxes, while the rest of the UI renders fine (using GTK theme font). With this change the server labels render correctly. Horizon renders its server labels with "DejaVu Sans" but fails to load the font when fontconfig resolves it to a symlinked file, which is what it finds if dejavu-fonts-minimal is installed on the host. This fix points the client at a fontconfig which maps DejaVu Sans to a font bundled in the FHS sandbox (Liberation Sans). Assisted-by: Claude Code (Claude Opus 4.8)
carlzulauf
force-pushed
the
fix-omnissa-horizon-client-tile-fonts
branch
from
4fcf706 to
17a6a2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the omnissa-horizon-client renders server labels as empty boxes, while the rest of the UI renders fine (using GTK theme font).
With this change the server labels render correctly.
(Exact server name was deliberately censored in screenshot)
Horizon renders its server labels with "DejaVu Sans" but fails to load the font when fontconfig resolves it to a symlinked file, which is what it finds if dejavu-fonts-minimal is installed on the host.
Things done
This fix points the client at a fontconfig which maps DejaVu Sans to a font bundled in the FHS sandbox (Liberation Sans).
Claude+Opus was used in locating the issue and creating the initial fix in my local nix config before I cleaned it up and created this PR. I have fully reviewed and tested the fix, including pointing my local config at this branch and confirming the fix works.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.