nixosTests.dashy: use systemd-nspawn instead of qemu#536839
Open
TheRealGramdalf wants to merge 1 commit into
Open
nixosTests.dashy: use systemd-nspawn instead of qemu#536839TheRealGramdalf wants to merge 1 commit into
TheRealGramdalf wants to merge 1 commit into
Conversation
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Switch the tests for
dashy-ui(which coversservices.dashy) fromnodestocontainers. Reduces test script time from 189.47s -> 6.99s (96% less) as tested locally.Machine name was changed from
machine-customtocustomto remain within the 15 character limit for network interfaces.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.