fix(trader): guard against division by zero and fix peak PnL logic#1422
Open
chulinhcql-art wants to merge 4 commits intoNoFxAiOS:devfrom
Open
fix(trader): guard against division by zero and fix peak PnL logic#1422chulinhcql-art wants to merge 4 commits intoNoFxAiOS:devfrom
chulinhcql-art wants to merge 4 commits intoNoFxAiOS:devfrom
Conversation
added 4 commits
March 21, 2026 01:07
…r short positions
Author
|
Please use this Base (USDC) wallet for the reward: 0x061E613F450AefC5Ca0dB1A7764AE0545c968811. Thank you! |
|
chulinhcql-art seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
chulinhcql-art seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Critical fix for potential crash (division by zero). Highly recommend merging this to protect system stability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical logic error in drawdown monitoring. It adds a safety check for zero entry prices and fixes the Peak PnL logic to correctly handle short positions. Authored by chulinhcql-art.