Skip to content

Add privilegedSupporterRoles option and refactor some hard to maintain code#10

Open
brentspine wants to merge 24 commits intoNoRiskClient:masterfrom
brentspine:master
Open

Add privilegedSupporterRoles option and refactor some hard to maintain code#10
brentspine wants to merge 24 commits intoNoRiskClient:masterfrom
brentspine:master

Conversation

@brentspine
Copy link
Copy Markdown
Member

@brentspine brentspine commented Jan 15, 2026

@brentspine brentspine changed the title Refactor some hard to maintain code (WIP) Add privilegedSupporterRoles option and refactor some hard to maintain code (WIP) Jan 15, 2026
@copyandexecute
Copy link
Copy Markdown
Collaborator

@BigBrainRobin29 @Alex1607 could you please check this pr?

@brentspine brentspine changed the title Add privilegedSupporterRoles option and refactor some hard to maintain code (WIP) Add privilegedSupporterRoles option and refactor some hard to maintain code Jan 15, 2026
…s. Secondary condition for ordering by rating is amount of ratings received
@brentspine
Copy link
Copy Markdown
Member Author

image

@brentspine
Copy link
Copy Markdown
Member Author

Ich find dieses Transkript eigentlich auch besser, weil man direkt sieht was war ohne die Datei herunterladen zu müssen. Die PR fügt diesen Infotext hinzu.

image

Comment thread src/main/java/eu/greev/dcbot/scheduler/DailyScheduler.java Outdated
Comment thread src/main/java/eu/greev/dcbot/scheduler/HourlyScheduler.java Outdated
Comment thread src/main/java/eu/greev/dcbot/scheduler/RatingStatsScheduler.java Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/interactions/commands/ConfigDump.java Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/interactions/commands/RatingStats.java Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/service/XpService.java Outdated
Comment thread src/main/java/eu/greev/dcbot/utils/Config.java Outdated
Comment thread src/main/java/eu/greev/dcbot/Main.java Outdated
Comment thread src/main/java/eu/greev/dcbot/Main.java
@brentspine brentspine requested a review from Alex1607 January 20, 2026 00:42
@enricoxD
Copy link
Copy Markdown
Member

enricoxD commented Feb 22, 2026

@BigBrainRobin29 @Alex1607 can you please check this again?

@BigBrainRobin29 BigBrainRobin29 self-requested a review April 19, 2026 00:33
Comment thread README.md Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/service/SupporterRatingStatsHelper.java Outdated
Comment thread src/main/java/eu/greev/dcbot/scheduler/RatingStatsScheduler.java Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/interactions/commands/RatingStats.java Outdated
try {
User user = jda.retrieveUserById(id).complete();
if (user != null) {
return user.getAsMention();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary api request as user.getAsMention() returns "<@" + id + ">"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/main/java/eu/greev/dcbot/ticketsystem/interactions/modals/TicketModal.java Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/service/XpService.java Outdated
Comment thread README.md Outdated
Comment thread src/main/java/eu/greev/dcbot/ticketsystem/interactions/modals/TicketModal.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DISCORD-BUG]: Supporters can view sensitive ticket info via /ticket info

5 participants