Fix/issue 283 validate stellar public keys - #357
Merged
Dami24-hub merged 2 commits intoJul 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strengthens input validation in
BalanceCheckToolby validating bothpublicKeyandassetIssueras real Stellar Ed25519 public keys usingStrKey.isValidEd25519PublicKey().Changes
StrKey.isValidEd25519PublicKey()validation forpublicKey.StrKey.isValidEd25519PublicKey()validation forassetIssuer.Why
Previously, both fields were only validated by string length, allowing invalid values that were not valid Stellar G-addresses to pass validation. This change ensures only valid Ed25519 public keys are accepted.
Acceptance Criteria
npm run buildpasses.Closes #283