Skip to content

fix: validate multisig additional signers as Ed25519 public keys - #358

Merged
Dami24-hub merged 1 commit into
Nodal-stellar:mainfrom
dinmacmd:fix/issue-284-validate-multisig-signers
Jul 30, 2026
Merged

fix: validate multisig additional signers as Ed25519 public keys#358
Dami24-hub merged 1 commit into
Nodal-stellar:mainfrom
dinmacmd:fix/issue-284-validate-multisig-signers

Conversation

@dinmacmd

Copy link
Copy Markdown
Contributor

This PR improves input validation in MultiSigPaymentTool by validating every entry in additionalSigners as a valid Stellar Ed25519 public key using StrKey.isValidEd25519PublicKey().

Changes

  • Added StrKey.isValidEd25519PublicKey() validation to each element in the additionalSigners array.
  • Updated tests to verify invalid signer public keys are rejected during schema validation.
  • Ensured only valid Stellar G-addresses are accepted for multisig signers.

Why

Previously, additionalSigners was only validated by string length (56 characters), allowing malformed or invalid Stellar public keys to pass validation. This change enforces proper Ed25519 public key validation, preventing invalid signer addresses from being accepted.

Acceptance Criteria

  • ✅ Invalid signer public keys are rejected during validation.
  • ✅ Tests updated.
  • npm run build passes.

Closes #284

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@dinmacmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Dami24-hub
Dami24-hub merged commit d5ffef1 into Nodal-stellar:main Jul 30, 2026
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security: MultiSigPaymentTool additionalSigners should be validated as real Ed25519 keys

2 participants