universal proxy support for function identifier lookup#1327
Open
wighawag wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 7c19076 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thank you for the PR. My review is delayed a little as I've been working on similar parts of the code to resolve #1325. Once I've finished and merged those changes, I'll resolve conflicts on your PR and give any additional feedback I might have. |
Contributor
Author
|
Hey @Wodann any update on this ? was it integrated in other PR ? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix NomicFoundation/hardhat#7434
better than #1324 as it supports any proxy, diamond ...
it is also simpler
Note that I modified the proxy chain detection logic to only match for the first 4 bytes so it supports things like clone-with-immutable-args that append data to the calldata