Skip to content

[DO NOT MERGE] ci: adopt Hardhat 3 E2E regression benchmarks#1488

Closed
Wodann wants to merge 6 commits into
NomicFoundation:mainfrom
Wodann:ci/regression-benchmarks
Closed

[DO NOT MERGE] ci: adopt Hardhat 3 E2E regression benchmarks#1488
Wodann wants to merge 6 commits into
NomicFoundation:mainfrom
Wodann:ci/regression-benchmarks

Conversation

@Wodann

@Wodann Wodann commented Jun 18, 2026

Copy link
Copy Markdown
Member

Test PR to validate new CI workflow:

  • A new workflow added from a fork does not run in CI checks
    • As a result, /bench comments don't work
  • [ ]

@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 61b6fc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann

Wodann commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

/bench

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Jun 18, 2026
Wodann added 6 commits June 18, 2026 16:12
Add scripts/publish_to_verdaccio.sh (with detect_edr_platform.cjs) as the
shared "build EDR locally -> publish to Verdaccio" flow: it stages the built
native binary into its platform package, compiles the bundled TS helpers, pins
the versions, wires the single platform dependency, and publishes both packages.

Wire the edr-regression-benchmark workflow to call it so the benchmark exercises
the locally-built EDR, and point the local-release docs and the
setup-verdaccio-env skill at the same script as the single source of truth.
Move the edr-regression-benchmark setup job's inline github-script logic into
.github/scripts/resolve-regression-trigger.cjs (required from a sparse-checked-out
copy) so it can be linted and unit-tested. Add Node built-in test-runner tests
covering the push, workflow_dispatch and issue_comment (/bench) paths, exposed as
the root `test:workflows` script and run in the edr-ci build-and-lint job.
Replace the inline 30-minute deadline and 30-second poll literals in the
regression-benchmark trigger resolver with CI_WAIT_TIMEOUT_MS and
CI_POLL_INTERVAL_MS so each can be tuned independently.
@Wodann Wodann force-pushed the ci/regression-benchmarks branch from fcd4d62 to 61b6fc9 Compare June 18, 2026 16:12
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.05%. Comparing base (bbee877) to head (61b6fc9).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1488       +/-   ##
===========================================
- Coverage   79.40%   47.05%   -32.35%     
===========================================
  Files         446      420       -26     
  Lines       76607    66963     -9644     
  Branches    76607    66963     -9644     
===========================================
- Hits        60830    31512    -29318     
- Misses      13656    34181    +20525     
+ Partials     2121     1270      -851     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wodann

Wodann commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

/bench

1 similar comment
@Wodann

Wodann commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

/bench

@github-actions

Copy link
Copy Markdown
Contributor

🚫 Regression benchmarks can only run for branches in this repository, not forks (the self-hosted runner must not execute untrusted code). Push your branch to NomicFoundation/edr and comment /bench again.

@Wodann

Wodann commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/bench

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🚫 Regression benchmarks can only run for branches in this repository, not forks (the self-hosted runner must not execute untrusted code). Push your branch to NomicFoundation/edr and comment /bench again.

@Wodann

Wodann commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Testing for the /bench command is complete. This PR is no longer necessary

@Wodann Wodann closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant