fix(desktop): guard ErrorService when logService is unavailable - #617
Open
ORuessel wants to merge 1 commit into
Open
fix(desktop): guard ErrorService when logService is unavailable #617ORuessel wants to merge 1 commit into
ORuessel wants to merge 1 commit into
Conversation
Prevent white screen / bootstrap failure when logService.log is not ready (e.g. TypeError: Cannot read properties of undefined (reading 'log')). Fallback to console.error; wrap logging in try/catch. Related: Noovolari#524 Signed-off-by: ORuessel <oruessel@gmx.de>
|
Author
|
The semantic-pull-request** (or related) check failed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent white screen / bootstrap failure when logService.log is not ready (e.g. TypeError: Cannot read properties of undefined (reading 'log')).
Fallback to console.error; wrap logging in try/catch.
Related: #524
Changelog
List of new feature and/or fixes here.
Bugfixes
Describe the fixes and specifying the issue if related.
Enhancements
Describe the enhancements specifying the issue if related.
Notes
Write eventual notes or reminders specifying if you have any sort of reference