Skip to content

Add startup probes and relax probe timings for CI stability - #2

Closed
efiacor wants to merge 1 commit into
mainfrom
relax_probe_timings
Closed

Add startup probes and relax probe timings for CI stability#2
efiacor wants to merge 1 commit into
mainfrom
relax_probe_timings

Conversation

@efiacor

@efiacor efiacor commented May 19, 2026

Copy link
Copy Markdown

Description

  • What changed: Added startupProbe to porch-server, porch-controllers, and function-runner. Increased readiness probe failureThreshold and periodSeconds. Added missing livenessProbe to function-runner.
  • Why it's needed: CI flakiness from pods being killed during slow startup when using kpt live apply.
  • How it works: Startup probes gate liveness/readiness checks, giving containers up to ~155s to initialize before any kill decisions are made.

Related Issue(s)

  • N/A (CI flakiness observed in deploy pipeline)

Type of Change

  • Bug fix
  • Enhancement

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

Testing Instructions (Optional)

  1. Deploy to kind cluster with make run-in-kind-v1alpha2
  2. Observe pods start without probe-related restarts
  3. Run e2e tests to confirm no regressions

Additional Notes (Optional)

  • Postgres probes were already well-configured (startup probe with 300s budget) — left unchanged
  • .build/deploy/ copies also updated locally but are gitignored

AI Disclosure

  • I have used AI in the creation of this PR.

If so, please describe how:

  • Kiro to analyse existing probe configurations and generate relaxed timings with startup probes.
  • The author has fully verified all code.

Add startupProbe to porch-server, porch-controllers, and function-runner
to prevent premature pod kills during slow CI startup. Increase readiness
failureThreshold and periodSeconds to tolerate transient delays.

Also adds a livenessProbe to function-runner which previously had none.

Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
@efiacor efiacor added the enhancement New feature or request label May 19, 2026
@efiacor efiacor self-assigned this May 19, 2026
@efiacor efiacor closed this May 19, 2026
@efiacor
efiacor deleted the relax_probe_timings branch May 19, 2026 13:51
@efiacor
efiacor restored the relax_probe_timings branch May 19, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant