Add startup probes and relax probe timings for CI stability - #2
Closed
efiacor wants to merge 1 commit into
Closed
Conversation
Add startupProbe to porch-server, porch-controllers, and function-runner to prevent premature pod kills during slow CI startup. Increase readiness failureThreshold and periodSeconds to tolerate transient delays. Also adds a livenessProbe to function-runner which previously had none. Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
startupProbeto porch-server, porch-controllers, and function-runner. Increased readiness probefailureThresholdandperiodSeconds. Added missinglivenessProbeto function-runner.kpt live apply.Related Issue(s)
Type of Change
Checklist
Testing Instructions (Optional)
make run-in-kind-v1alpha2Additional Notes (Optional)
.build/deploy/copies also updated locally but are gitignoredAI Disclosure
If so, please describe how: