Implement SGR 39 and 49#134
Open
IpsumCapra wants to merge 1 commit intoNorth-Western-Development:1.20.1from
Open
Implement SGR 39 and 49#134IpsumCapra wants to merge 1 commit intoNorth-Western-Development:1.20.1from
IpsumCapra wants to merge 1 commit intoNorth-Western-Development:1.20.1from
Conversation
SGR 39 and 49 were not implemented which caused the terminal to be unable to reset to the default foreground / background, respectively. This is mostly a problem with programs like tmux which heavily rely on these escape sequences.
|
Oh, is this also what can cause issues if you enable Nano syntax highlighting? |
Author
|
I would assume so, it (also) fixes the syntax highlighting for my Vim build. I don't see why it wouldn't work for Nano. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape sequences SGR 39 and 49 were not implemented which caused the terminal to be unable to reset to the default foreground / background, respectively. This is mostly a problem with programs like tmux which heavily rely on these escape sequences.
Example
The problem is clear to see when using the
tmuxclock (shown usingC-b t)Without SGR 49 implemented:
With SGR 49 implemented: