Skip to content

feat: Add unit test workflow and rename service health checks#187

Closed
NotYuSheng wants to merge 3 commits into
devfrom
feat/github-workflows
Closed

feat: Add unit test workflow and rename service health checks#187
NotYuSheng wants to merge 3 commits into
devfrom
feat/github-workflows

Conversation

@NotYuSheng

Copy link
Copy Markdown
Owner

Summary

  • Added new unit test workflow using existing scripts/test-all-services.sh
  • Renamed integration-test workflow to service-health-checks for clarity
  • Disabled E2E tests since frontend is not ready

Changes Made

  • New workflow: .github/workflows/unit-tests.yml
    • Runs comprehensive unit tests for all 7 services (206+ tests)
    • Includes disk space optimization for GitHub runners
    • Uploads test logs on failure
  • Renamed workflow: integration-test.yamlservice-health-checks.yml
    • Updated names to reflect actual functionality (service health checks)
    • Removed Node.js/Cypress placeholder steps
  • Disabled E2E: Renamed e2e-tests.yml to .disabled extension

Test Plan

  • Unit test workflow runs successfully
  • Service health checks workflow runs successfully
  • All services build and pass health checks individually
  • Test artifacts are properly uploaded on failure

🤖 Generated with Claude Code

NotYuSheng and others added 2 commits September 5, 2025 01:11
## Changes Made
- **Unit Test Workflow**: Created `.github/workflows/unit-tests.yml` using existing `./scripts/test-all-services.sh`
- **Disabled Cypress**: Created `.github/workflows/e2e-tests.yml.disabled` since frontend is not ready for E2E testing
- **Documentation**: Updated CLAUDE.md to reflect current testing status

## Testing Infrastructure Updates
- **Automated Unit Tests**: GitHub Actions will now run all 206+ unit tests across 7 services
- **CI Integration**: Unit tests run on push/PR to dev branch
- **Resource Management**: Includes disk space cleanup and Docker optimization
- **Artifact Upload**: Test logs uploaded on failure for debugging

## Rationale
- Replace integration testing approach with comprehensive unit test automation
- Preserve Cypress setup for future use when frontend is ready
- Maintain consistent testing standards while improving CI efficiency

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Renamed .github/workflows/integration-test.yaml to service-health-checks.yml
- Updated workflow name and job name to reflect actual functionality
- Removed Node.js and Cypress setup steps since they were placeholder-only
- Workflow now focuses purely on service health checks: build, start, and verify each *_service

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

- Updated unit-tests.yml to test services individually with health checks
- Each service gets built, dependencies started, health checked, then unit tested
- Removed separate service-health-checks.yml workflow to avoid duplication
- Added proper resource management with container cleanup between tests
- Workflow now efficiently combines health validation and unit testing

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@NotYuSheng NotYuSheng closed this Sep 4, 2025
@NotYuSheng NotYuSheng deleted the feat/github-workflows branch September 4, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant