feat: Remove chat feature from OmniPDF#207
Conversation
This reverts commit dabf0b2.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Summary of ChangesHello @NotYuSheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactor to remove the experimental chat feature from OmniPDF. The decision was made due to the feature not meeting quality standards, allowing the project to concentrate on its core PDF processing capabilities. The changes involve a comprehensive cleanup across the entire stack, from application code and UI to infrastructure configurations and documentation, resulting in a leaner and more maintainable system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
There was a problem hiding this comment.
Code Review
This pull request does an excellent job of removing the chat feature and its related components from the codebase. The cleanup is extensive, covering application code, configuration, infrastructure definitions, CI/CD scripts, and documentation. The changes are consistent with the goal of excising the feature entirely. I've found a few minor inconsistencies in the documentation files that seem to be leftovers from the refactoring, which I've pointed out in the specific comments. Overall, this is a solid cleanup effort that improves the maintainability of the project.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request does an excellent job of removing the chat feature and all its related components from the codebase. The cleanup is comprehensive, covering service code, Helm charts, documentation, and CI/CD scripts. The changes significantly reduce the complexity of the project and improve maintainability.
My review focuses on further enhancing the maintainability of the automation scripts, which currently rely on hardcoded service lists. By making these scripts more dynamic, they will be more resilient to future changes. I've added a few suggestions to refactor these scripts for better long-term maintenance.
User description
Summary
The chat feature was not performing well and has been removed from the codebase. This PR cleans up all related code, configuration, documentation, and infrastructure components.
Changes Made
chat_servicedirectory (18 files including Dockerfile, routes, models, tests)helm/chat-serviceHelm chart (14 files)pdf_processor_servicefrontend/my_pages/5_chat_UI.py)pdf_processor_service(kept sentence embedder for metadata)docker-compose.ymlto remove chat_service containertest-all-services.sh,test-single-service.sh)scan_with_trivy.sh)deploy-helm-charts.sh)Context / Rationale
The chat feature was experimental and not meeting quality standards. Rather than continue iterating on it, we've decided to remove it entirely and focus on the core PDF processing features. A version with chat is tagged for future reference if we decide to revisit this functionality.
Statistics Updated:
This is a refactor/cleanup to improve codebase maintainability and reduce complexity.
Related Docs or References
c4-diagram.puml)FastAPI Application Checklist (Delete if PR is not relevant)
N/A - This PR removes a service rather than adding/modifying FastAPI endpoints.
General Checklist
PR Type
Other
Description
Remove chat service and all related components
Update network policies and RBAC configurations
Clean up documentation and deployment scripts
Remove semantic embedder workflow from processing
Diagram Walkthrough
File Walkthrough
6 files
Remove chat URL environment variableRemove chat-service from deployment listRemove chat-service secret creation logicRemove chat_service from scan listRemove chat_service from test listUpdate example API endpoint configuration2 files
Remove semantic embedder workflowRemove chat router import11 files
Update example commands without chat serviceUpdate architecture and service countsUpdate examples without chat-service referencesReplace chat service examples with extraction serviceRemove chat service from architecture diagramUpdate service counts and examplesUpdate examples without chat-service referencesUpdate RBAC documentation for 13 servicesRemove chat-service from network policy examplesUpdate deployment examples without chat serviceRemove chat reference from description53 files