Skip to content

Check from_name in smtp sent emails#66

Closed
pierre-b wants to merge 13 commits into
devfrom
cursor/check-from-name-in-smtp-sent-emails-df10
Closed

Check from_name in smtp sent emails#66
pierre-b wants to merge 13 commits into
devfrom
cursor/check-from-name-in-smtp-sent-emails-df10

Conversation

@pierre-b

Copy link
Copy Markdown
Contributor

Add integration tests to verify from_name is correctly included in SMTP email headers by checking raw Mailhog messages.


Open in Cursor Open in Web

Co-authored-by: pierre <pierre@bazoge.com>
@cursor

cursor Bot commented Oct 23, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.54%. Comparing base (9fb474b) to head (29c0f02).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
internal/service/email_service.go 89.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #66      +/-   ##
==========================================
+ Coverage   81.51%   81.54%   +0.02%     
==========================================
  Files         148      148              
  Lines       27941    27978      +37     
==========================================
+ Hits        22777    22815      +38     
+ Misses       4081     4076       -5     
- Partials     1083     1087       +4     
Flag Coverage Δ
unit 81.54% <89.18%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cursoragent and others added 12 commits October 23, 2025 19:54
Co-authored-by: pierre <pierre@bazoge.com>
This change enables the `from_name` to be overridden from channel settings, providing more flexibility in email sender identification.

Co-authored-by: pierre <pierre@bazoge.com>
Tests ensure default sender name is used in email headers when not explicitly set.

Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
@pierre-b pierre-b closed this Oct 24, 2025
@pierre-b
pierre-b deleted the cursor/check-from-name-in-smtp-sent-emails-df10 branch October 31, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants