Check from_name in smtp sent emails#66
Closed
pierre-b wants to merge 13 commits into
Closed
Conversation
Co-authored-by: pierre <pierre@bazoge.com>
|
Cursor Agent can help with this pull request. Just |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #66 +/- ##
==========================================
+ Coverage 81.51% 81.54% +0.02%
==========================================
Files 148 148
Lines 27941 27978 +37
==========================================
+ Hits 22777 22815 +38
+ Misses 4081 4076 -5
- Partials 1083 1087 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: pierre <pierre@bazoge.com>
This change enables the `from_name` to be overridden from channel settings, providing more flexibility in email sender identification. Co-authored-by: pierre <pierre@bazoge.com>
Tests ensure default sender name is used in email headers when not explicitly set. Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests to verify
from_nameis correctly included in SMTP email headers by checking raw Mailhog messages.