Restore classic/remastered multiuser start menu entries in installer & folder selection in executable if game cannot be detected - #944
Merged
Conversation
Novum
force-pushed
the
better-installer-experience
branch
2 times, most recently
from
July 9, 2026 23:06
2815f6e to
98d3fe7
Compare
The store-detection port (f75b0e6) silently dropped -multiuser from the installer shortcut, moving configs and saves from %APPDATA%\vkQuake into the game directory, and left users without a Steam/GOG/Epic install staring at the missing-data error (#943). The installer now creates "vkQuake (classic)" and "vkQuake (remastered)" start menu entries again, passing -multiuser plus -original/-remastered so each shortcut launches its version directly instead of prompting every start when both are installed. When the requested version is not found by store detection, the engine opens a native folder picker (IFileOpenDialog on Windows) and remembers a valid selection in basedirs.txt in the pref dir; a folder without the required data (id1/pak0.pak or QuakeEX.kpf per flavor) shows a warning and asks again without storing it. A bare launch with no data found at all gets the same dialog instead of the missing-data error. Detected store paths are now validated per flavor as well. Fixes #943
Novum
force-pushed
the
better-installer-experience
branch
from
July 9, 2026 23:07
98d3fe7 to
0dc221d
Compare
- Sys_SelectFolder distinguishes dialog errors from cancel: cancel exits cleanly, errors fall through to the missing-data error - Store detection also runs when the working directory has no data for the version requested with -original/-remastered - Keep the remembered basedirs in memory instead of re-reading basedirs.txt before writing it back - Add COM_FOpenPrefFile and use it for all pref dir file access
Novum
force-pushed
the
better-installer-experience
branch
from
July 10, 2026 00:51
c72212b to
933a57a
Compare
Collaborator
|
What are the codecs mingw import library changes for ??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.