Extract particle spawner logic from tater blocks#182
Open
haykam821 wants to merge 9 commits intoNucleoidMC:mainfrom
Open
Extract particle spawner logic from tater blocks#182haykam821 wants to merge 9 commits intoNucleoidMC:mainfrom
haykam821 wants to merge 9 commits intoNucleoidMC:mainfrom
Conversation
Contributor
Author
|
I have updated this pull request; it now includes codecs for tater particle spawners. This attachment describes the block definitions (and by extension, the tater particle spawner definitions) for every Nucleoid Extras block. This pull request should be ready to review now. I'm curious whether the tater blocks could be registered from JSON in a future pull request. Having each tater block defined in a separate file would be extremely helpful for readability and ability for first-time contributors to add new taters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request separates the many particle implementations from tater blocks, meaning any tater block behavior can be matched with a specific style of particles. In addition, particle spawner implementations are less reliant on the concepts of players and block positions, so less work would be needed to attach particles in a new context in the future.
I'm unsure of whether tater particle spawner codecs should be included in this pull request.These codecs have been added to this pull request; they are referenced in tater block codecs.