Address review comments on RFC #985#14
Merged
NullVoxPopuli merged 1 commit intoNullVoxPopuli:v2-addon-by-defaultfrom Apr 9, 2026
Merged
Conversation
- Add note about addon/app blueprint parity gap in Motivation (kategengler) - Expand "Why single-package" with historical context about the earlier monorepo-based v2 blueprint (kategengler) - Document ember-cli-update version boundary for v1-to-v2 migration (kategengler) - Add section on ember-cli generators not working in v2 addons and what addon authors should do instead (kategengler) - Add bullet about reviewing existing Guides for incompatible workflows Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
NullVoxPopuli
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses several review comments from kategengler on emberjs#985:
@embroider/addon-blueprintrequiring a monorepo, and why that's no longer necessaryember-cli-updatecannot automatically migrate from v1 to the new blueprint (same pattern as the app blueprint transition)ember generatecommands won't work in v2 addons (noember-clidependency) and what addon authors should do insteadTest plan
🤖 Generated with Claude Code