feat(val): re-align VAL-2 checked insertion with merged leanSpec#1185 - #59
Merged
Conversation
Upstream leanEthereum/leanSpec#1185 (closes #1184) now rejects a manifest whose attestation and proposal public keys coincide, at load time and without touching secret bytes. The model's addChecked previously compared PRF seeds as a placeholder for the invited fix; re-align it with the merged shape: - addChecked now compares public keys, with the Arklib-side derivation entering as the publicKeyOf parameter (the repo's crypto-as-parameter pattern). - addChecked_wellFormed holds for every derivation: distinct public keys imply distinct secret keys by congruence alone. - addChecked_seed_distinct keeps the OTS-reuse core of #1184: for seed-fingerprinting derivations an accepted entry's keys have distinct master seeds. - Registry.lean and catalog docstrings drop the stale 'upstream does not enforce' caveat: WellFormed is established by construction since #1185.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream leanEthereum/leanSpec#1185 (closes #1184, merged as
ae104fab) now enforces the dual-key separation the formalization found unenforced: the registry loader rejects a manifest whose attestation and proposal public keys coincide, before any secret key is decoded. This PR re-aligns the Lean model with the merged fix, as planned whenaddCheckedwas introduced in #58.Changes
addCheckednow mirrors the merged shape: it compares public keys instead of PRF seeds, with the Arklib-side derivation entering as thepublicKeyOfparameter (the repo's crypto-as-parameter pattern).addChecked_wellFormedis proved for every derivation — distinct public keys imply distinct secret keys by congruence alone, no cryptographic assumption needed.addChecked_seed_distinctpreserves the OTS-reuse core of #1184: for derivations that fingerprint the master seed, an accepted entry's two keys have distinct seeds, so one slot's proposal + attestation signatures can never consume overlapping one-time-signature state.Registry.leanmodule docstring and the catalog's VAL-2 entry drop the stale "upstream does not enforce" caveat:WellFormedis now established by construction at load time.Verification
lake buildsucceeds (35 jobs), nosorry, no new axioms.