Take line breaks into account for redundant periods#528
Open
engboris wants to merge 2 commits intoOCamlPro:masterfrom
Open
Take line breaks into account for redundant periods#528engboris wants to merge 2 commits intoOCamlPro:masterfrom
engboris wants to merge 2 commits intoOCamlPro:masterfrom
Conversation
Collaborator
|
In this particular case may the period after |
Contributor
Author
|
Hmm I merged with master and got a lot of weird output on |
9bb9295 to
78d9822
Compare
nberth
reviewed
Feb 13, 2026
| 17 > IF OK NOT EQUAL "OK" DISPLAY OK. | ||
| ---- ^^ | ||
| >> Error: Invalid syntax | ||
|
|
Collaborator
There was a problem hiding this comment.
This here seems to be an issue unfortunately.
78d9822 to
7c8ded3
Compare
7c8ded3 to
8b93d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a fix for redundant periods: #521
However, it doesn't take line breaks into account, as in:
I tried a new fix and the
check syntaxcommands succeeds but I'm not sure about it as I'm not sure to understand exactly how tokens are manipulated. Moreover, the tests I have promoted look suspicious.