Add comprehensive test suite with Alcotest#3
Merged
redianthus merged 5 commits intoOCamlPro:mainfrom Oct 3, 2025
Merged
Conversation
Member
|
💀 |
Contributor
Author
|
J'ai rien relu yolomdr |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Extract synchronizer creation into helper functions - Add make_queue_sync() and make_queue_sync_broadcast() - Add make_counter_worker() for thread-safe counting - Add run_domains() to spawn and join domain arrays - Reduce code duplication from 474 to 329 lines - All tests still pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Per the synchronizer documentation: - Use Condition.signal when adding a single work unit - Use Condition.broadcast when adding multiple work units Since Queue.push adds exactly one item at a time, signal is correct and more efficient. Broadcast would wake all waiting threads unnecessarily when only one can retrieve the item. Changes: - Replace all Condition.broadcast with Condition.signal in queue writers - Remove redundant make_queue_sync_broadcast function - Add documentation explaining the choice 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive test suite for the Synchronizer library using the Alcotest framework, along with code coverage measurement using bisect_ppx.
Changes
Test Suite: Added 15 tests covering all major functionality:
work_whilehelper functionDependencies:
alcotestas a test dependencybisect_ppxinstrumentation for code coverageCoverage: Achieves 100% code coverage (35/35 points)
Test Organization
Tests are organized into 6 test suites:
Running Tests
All tests pass successfully and verify thread-safe operations, pledge management, synchronization primitives, and proper termination conditions across multiple domains.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com