Chat attachments UI#257
Conversation
Josue19-08
left a comment
There was a problem hiding this comment.
Hi @olaleyeolajide81-sketch, there is a serious problem with this PR: it includes commit 3fc969c which is the wallet fix (issue #196) — that commit deletes wallet.ts mock data and modifies wallet/page.tsx, and it belongs to your other PR #256, not here. The chat attachments PR should only contain the attachment-related changes. Please rebase this branch to remove the wallet commit from it, keeping only commit 89c9d40 (the actual attachments implementation). Additionally, the PR description does not use the template and only lists acceptance criteria without explaining what was built or how to test it — please fill that in as well.
Josue19-08
left a comment
There was a problem hiding this comment.
Hi @olaleyeolajide81-sketch, the chat attachment implementation looks solid and the description now covers the acceptance criteria. One blocker remains: src/app/app/wallet/page.tsx is still in this PR's diff — it contains the ErrorState changes that belong to your PR #256, not here. If both PRs are merged, that file will be applied twice and cause a conflict. Please rebase this branch to drop the wallet/page.tsx changes, keeping only the chat attachment files (AttachmentButton.tsx, AttachmentPreview.tsx, MessageAttachment.tsx, MessageBubble.tsx, MessageInput.tsx, chat-attachments.ts, chat.types.ts).
…rop wallet changes
2c333db to
408533f
Compare
|
The branch has been rebased appropriately for your review. |
|
Dear Josue,
The branch repo has been rebased appropriately for your review in the
Github.
Kindly review and merge PR.
Thank You
…On Thu, Jun 4, 2026, 5:04 PM Josué Araya Marín ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @olaleyeolajide81-sketch <https://github.com/olaleyeolajide81-sketch>,
the chat attachment implementation looks solid and the description now
covers the acceptance criteria. One blocker remains:
src/app/app/wallet/page.tsx is still in this PR's diff — it contains the
ErrorState changes that belong to your PR #256
<#256>, not here. If
both PRs are merged, that file will be applied twice and cause a conflict.
Please rebase this branch to drop the wallet/page.tsx changes, keeping only
the chat attachment files (AttachmentButton.tsx, AttachmentPreview.tsx,
MessageAttachment.tsx, MessageBubble.tsx, MessageInput.tsx,
chat-attachments.ts, chat.types.ts).
—
Reply to this email directly, view it on GitHub
<#257?email_source=notifications&email_token=B6KKT567DJCO3U4YMZ3IAIL46GMZJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSHE2DGNJZGU2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4429435954>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B6KKT5ZOXWIF6KGQ273DM3346GMZJAVCNFSM6AAAAACZTXDUKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DIMRZGQZTKOJVGQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/B6KKT552XKQH7ZRAKEXQRK346GMZJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSHE2DGNJZGU2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/B6KKT54Y5M5YGBC2AS3TULD46GMZJA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSHE2DGNJZGU2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Josue19-08
left a comment
There was a problem hiding this comment.
Hi @olaleyeolajide81-sketch, good progress — wallet/page.tsx is no longer in the diff. The chat attachment files are the only changes now. Two items remain before this can be merged: (1) The PR description still does not use the repository template (.github/PULL_REQUEST_TEMPLATE.md). It currently lists acceptance criteria but is missing the required sections: Title, Issue (Closes #139), Description, Changes applied, Evidence/Media. Please rewrite it using the template. (2) No screenshots or evidence have been provided showing the attachment UI working in the chat. Add at least one screenshot or screen recording embedded in the PR description.
📘 Description
Implement file attachment support in chat, allowing users to share documents, images, and other files.
✅ Acceptance Criteria
Create AttachmentButton component for message input
Create AttachmentPreview component before sending
Create MessageAttachment component for displaying in messages
Support multiple file selection
Show file type icons based on mime type
Display file size and name
Show upload progress indicator
Support image preview in chat
Add download button for attachments
Validate file types and sizes client-side
Handle upload errors with retry option
Create API client for attachment upload
Ensure responsive design
closes #139