Skip to content

Chat attachments UI#257

Open
olaleyeolajide81-sketch wants to merge 2 commits into
OFFER-HUB:mainfrom
olaleyeolajide81-sketch:Chat-Attachments-UI
Open

Chat attachments UI#257
olaleyeolajide81-sketch wants to merge 2 commits into
OFFER-HUB:mainfrom
olaleyeolajide81-sketch:Chat-Attachments-UI

Conversation

@olaleyeolajide81-sketch

Copy link
Copy Markdown

📘 Description
Implement file attachment support in chat, allowing users to share documents, images, and other files.

✅ Acceptance Criteria
Create AttachmentButton component for message input
Create AttachmentPreview component before sending
Create MessageAttachment component for displaying in messages
Support multiple file selection
Show file type icons based on mime type
Display file size and name
Show upload progress indicator
Support image preview in chat
Add download button for attachments
Validate file types and sizes client-side
Handle upload errors with retry option
Create API client for attachment upload
Ensure responsive design

closes #139

@Josue19-08 Josue19-08 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olaleyeolajide81-sketch, there is a serious problem with this PR: it includes commit 3fc969c which is the wallet fix (issue #196) — that commit deletes wallet.ts mock data and modifies wallet/page.tsx, and it belongs to your other PR #256, not here. The chat attachments PR should only contain the attachment-related changes. Please rebase this branch to remove the wallet commit from it, keeping only commit 89c9d40 (the actual attachments implementation). Additionally, the PR description does not use the template and only lists acceptance criteria without explaining what was built or how to test it — please fill that in as well.

@Josue19-08 Josue19-08 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olaleyeolajide81-sketch, the chat attachment implementation looks solid and the description now covers the acceptance criteria. One blocker remains: src/app/app/wallet/page.tsx is still in this PR's diff — it contains the ErrorState changes that belong to your PR #256, not here. If both PRs are merged, that file will be applied twice and cause a conflict. Please rebase this branch to drop the wallet/page.tsx changes, keeping only the chat attachment files (AttachmentButton.tsx, AttachmentPreview.tsx, MessageAttachment.tsx, MessageBubble.tsx, MessageInput.tsx, chat-attachments.ts, chat.types.ts).

@olaleyeolajide81-sketch

Copy link
Copy Markdown
Author

The branch has been rebased appropriately for your review.

@olaleyeolajide81-sketch

olaleyeolajide81-sketch commented Jun 5, 2026 via email

Copy link
Copy Markdown
Author

@Josue19-08 Josue19-08 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olaleyeolajide81-sketch, good progress — wallet/page.tsx is no longer in the diff. The chat attachment files are the only changes now. Two items remain before this can be merged: (1) The PR description still does not use the repository template (.github/PULL_REQUEST_TEMPLATE.md). It currently lists acceptance criteria but is missing the required sections: Title, Issue (Closes #139), Description, Changes applied, Evidence/Media. Please rewrite it using the template. (2) No screenshots or evidence have been provided showing the attachment UI working in the chat. Add at least one screenshot or screen recording embedded in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat Attachments UI

3 participants