fix: refresh backend JWT via API#269
Conversation
Josue19-08
left a comment
There was a problem hiding this comment.
Hi @khanavi272-spec, thanks for connecting the refresh route to the real backend — removing the simulated token is the right call. Two issues before merging: 1. The PR description is empty — it only says 'Closes #209' with no explanation of what changed or why. Please fill in the repository template (.github/PULL_REQUEST_TEMPLATE.md) with title, description, changes applied, and at least one screenshot or test result as evidence. 2. The backend does not currently expose a POST /auth/refresh endpoint — please verify the endpoint exists and returns { data: { token, refreshToken } } before this goes to production, or note in the PR how you tested it.
|
kindly merge @Josue19-08 Thanks for the review. I updated the PR description with the requested summary, implementation details, and testing notes. I also verified the refresh flow implementation. The frontend refresh route ( Please let me know if you would like any additional verification or testing evidence. |
Josue19-08
left a comment
There was a problem hiding this comment.
Hi @khanavi272-spec, the code change is correct — simulated tokens replaced with a real call to the backend /auth/refresh endpoint, proper error handling added. However the previous review requested changes that are still unresolved after one week: (1) The PR description does not use the repository template (.github/PULL_REQUEST_TEMPLATE.md) — it uses a custom Summary/Changes/Testing format instead. Please rewrite it using the template sections: Title, Issue (Closes #209), Description, Changes applied, Evidence/Media. (2) No screenshot or test result has been provided as evidence. Please add at least one piece of evidence showing the refresh flow working (e.g. a network screenshot or test output).
Summary
Connect NextAuth refresh flow to the backend refresh endpoint instead of using simulated tokens.
Changes Made
Testing
Closes #209