fix(dispute-evidence): remove NEXT_PUBLIC_USE_MOCKS feature flag#298
Open
Benjtalkshow wants to merge 1 commit into
Open
fix(dispute-evidence): remove NEXT_PUBLIC_USE_MOCKS feature flag#298Benjtalkshow wants to merge 1 commit into
Benjtalkshow wants to merge 1 commit into
Conversation
The dispute evidence API read NEXT_PUBLIC_USE_MOCKS and, when set, returned fabricated evidence instead of hitting the real endpoints. The flag was undocumented, so an accidental deployment setting could silently serve fake data. Drop the USE_MOCKS constant and the mock branches in uploadDisputeEvidence, listDisputeEvidence and deleteDisputeEvidence so all three always call the real API. Errors continue to propagate to the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290
What this does
Removes the
NEXT_PUBLIC_USE_MOCKSfeature flag fromsrc/lib/api/dispute-evidence.ts.The file used to read
process.env.NEXT_PUBLIC_USE_MOCKSand, when it was set, returned fake evidence objects instead of calling the real API. The flag wasn't documented anywhere, so if it ever got set by accident in a deployment, the app would quietly serve fabricated data instead of real dispute evidence.Changes
USE_MOCKSconstantuploadDisputeEvidence,listDisputeEvidenceanddeleteDisputeEvidenceNotes
NEXT_PUBLIC_USE_MOCKSwas not present in.env.exampleor any config, so nothing to clean up there.dispute.data.ts, so no import cleanup needed.tsc --noEmitpasses for the file.