Skip to content

Hide menu options until user has logged in #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pieterlukasse wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hide menu options until user has logged in #3004

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5ae38
fix: hide menu options until user has logged in
pieterlukasse Jun 27, 2024
678afc2
fix: change computed to pureComputed for isLoggedIn
pieterlukasse Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@
</div>

<div class="app__menu">
<!-- ko if: isLoggedIn -->
<!-- ko foreach: router.pages -->
<a data-bind="visible: !$data.hidden, attr: {href: navUrl()}, css: $parent.classes({ element: 'menu-item', modifiers: $parent.router.activeRoute().title === $data.title ? 'selected' : '', extra: statusCss() })">
<i data-bind="css: $parent.classes({ element: 'menu-icon', extra: `fa fa-fw fa-${icon}`})" aria-hidden="true"></i>
<span data-bind="text: $data.title, css: $parent.classes('menu-title')"></span>
</a>
<!-- /ko -->
<!-- /ko -->
</div>

<!-- ko if: !companyInfoTemplate && showCompanyInfo-->
Expand Down
1 change: 1 addition & 0 deletions js/Application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ define(
});
this.companyInfoTemplate = config.companyInfoCustomHtmlTemplate;
this.showCompanyInfo = config.showCompanyInfo;
this.isLoggedIn = ko.computed(() => authApi.isAuthenticated());
Comment thread
pieterlukasse marked this conversation as resolved.
Outdated
}

/**
Expand Down