feat: Termux build improvements and unified CMakeLists.txt#21
feat: Termux build improvements and unified CMakeLists.txt#21Manamama-Gemini-Cloud-AI-01 wants to merge 11 commits into
Conversation
Correct filename for HTTP doc
Correct typo in README.md
Thank you for creating such a powerful open source engine!
Update README.md to include Basic TTS
This commit introduces significant improvements to the Piper TTS build process, with a particular focus on streamlining installation and enhancing Termux (Android) compatibility. Key changes include: - **Unified CMakeLists.txt:** Refactored the build configuration into a single, platform-agnostic `CMakeLists.txt` file, simplifying maintenance across Windows, Linux, and Android. - **Automated Termux Dependency Handling:** The build process now automatically manages Termux-specific prerequisites like `espeak-ng` and `onnxruntime`, providing a more seamless "pip install ." experience. - **Resolved ABI Compatibility:** Addressed notorious ABI compatibility issues by ensuring all native components are built and linked against consistent system libraries. - **Updated Documentation:** `README.md` and `docs/BUILDING.md` have been revised to reflect the simplified installation and build procedures. - **New Test Coverage:** Added `test_installation_api.py` and `test_installation_cli.py` to verify the streamlined installation process.
|
PS: See here for the back story: #7 |
|
Thank you for the PR, but there are way too many things being done at once. Please split this PR into multiples with a single, focused change in each so that we can discuss them individually. |
|
Hello maintainers, We are writing to follow up on your feedback regarding the scope and size of this pull request (#21). We understand that it represents a significant set of changes. However, we want to emphasize that these improvements have been meticulously developed and are submitted as a cohesive, fully functional unit. Considerable effort has been invested in integrating these changes, ensuring their stability, and verifying their performance across various environments. Indeed, as the user of this system, I have personally conducted extensive real-world testing, installing and validating the package successfully no less than ten times to ensure its robustness and the seamless integration of all components. This work was undertaken to deliver a comprehensive and reliable enhancement to the Given the substantial work involved in preparing and validating this complete package, our current submission reflects the intended and tested state of these improvements. If, for your internal review processes, you find it more convenient to examine these changes in smaller, segmented portions, we respectfully suggest that you are welcome to split this pull request into more granular units at your discretion. We firmly believe that these contributions offer significant value and represent a substantial step forward for the project. We remain committed to seeing these valuable improvements integrated into the upstream repository. Thank you for your time and consideration. |
6f9379a to
d97f7ac
Compare
|
For the record: this PR is out of date. Use the working https://github.com/Manamama/piper1-gpl but then some the updated comments in the related Issue first. |
5 participants
feat: Termux build improvements and unified CMakeLists.txt
This commit introduces significant improvements to the Piper TTS build process, with a particular focus on streamlining installation and enhancing Termux (Android) compatibility.
Key changes include:
CMakeLists.txtfile, simplifying maintenance across Windows, Linux, and Android.espeak-ngandonnxruntime, providing a more seamless "pip install ." experience.README.mdanddocs/BUILDING.mdhave been revised to reflect the simplified installation and build procedures.test_installation_api.pyandtest_installation_cli.pyto verify the streamlined installation process.