detect/integer: support missing modes for u8 prefilter#13754
detect/integer: support missing modes for u8 prefilter#13754catenacyber wants to merge 1 commit into
Conversation
Ticket: 7865 <=, >=, and != were missing Also warns if an unimplemented mode is tried
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13754 +/- ##
===========================================
+ Coverage 77.16% 83.73% +6.56%
===========================================
Files 945 1011 +66
Lines 172228 275112 +102884
===========================================
+ Hits 132906 230359 +97453
- Misses 39322 44753 +5431
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 27235 |
|
This should not affect QA as QA does not use signatures with these prefilters, right ? |
|
Information: QA ran without warnings. Pipeline = 27256 |
|
Can we get more tests going for this? Coverage of about 30% is really low for something that should be easy to test. |
Right, I updated the SV PR. How can we get codecov to run again ? |
|
Merged in #13767, thanks! |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7865
Describe changes:
SV_BRANCH=OISF/suricata-verify#2625
#13751 with better commit message