Skip to content

detect/integer: support missing modes for u8 prefilter#13754

Closed
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:detect-integer-prefilter-7865-v2
Closed

detect/integer: support missing modes for u8 prefilter#13754
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:detect-integer-prefilter-7865-v2

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7865

Describe changes:

  • detect/integer: support more (all) modes for u8 prefilter

SV_BRANCH=OISF/suricata-verify#2625

#13751 with better commit message

Ticket: 7865

<=, >=, and != were missing

Also warns if an unimplemented mode is tried
@codecov

codecov Bot commented Aug 27, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.43478% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.73%. Comparing base (49629f7) to head (2b6de9f).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #13754       +/-   ##
===========================================
+ Coverage   77.16%   83.73%    +6.56%     
===========================================
  Files         945     1011       +66     
  Lines      172228   275112   +102884     
===========================================
+ Hits       132906   230359    +97453     
- Misses      39322    44753     +5431     
Flag Coverage Δ
fuzzcorpus 62.92% <0.00%> (-0.01%) ⬇️
livemode 19.13% <0.00%> (+0.13%) ⬆️
pcap 44.70% <0.00%> (+0.02%) ⬆️
suricata-verify 65.11% <30.43%> (+0.03%) ⬆️
unittests 59.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 648 627 96.76%

Pipeline = 27235

@catenacyber

Copy link
Copy Markdown
Contributor Author

This should not affect QA as QA does not use signatures with these prefilters, right ?

@suricata-qa

Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 27256

@victorjulien

Copy link
Copy Markdown
Member

Can we get more tests going for this? Coverage of about 30% is really low for something that should be easy to test.

@catenacyber

Copy link
Copy Markdown
Contributor Author

Can we get more tests going for this? Coverage of about 30% is really low for something that should be easy to test.

Right, I updated the SV PR.

How can we get codecov to run again ?

@victorjulien victorjulien added this to the 8.0 milestone Aug 29, 2025
@victorjulien

Copy link
Copy Markdown
Member

Merged in #13767, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants