next/970/20250827/v1#13755
Merged
Merged
Conversation
de_ctx->rule_file is never NULL inside DetectFileHashParse(); add a comment stating this fact and remove the superfluous NULL guard. No functional change – the patch only clarifies the code and trims a few lines of dead code. Bug 7769
In util-hash.c there was some behavior that is unexpected and likely incorrect. To see this behavior, create a hash table 32 entries wide and use the default hash function. Then add a short string “abc”, observe the string is stored properly. Now remove a string “iln”, and observe string “abc” is no longer in the table. This is because the hash function is not properly handling collisions in some edge cases. Includes new unit test: - UT verifies that the hash function generates a collision for the selected test data. This must be true for the bug to be present. Then UT demonstrates the bug by adding two items to the hash table that collide, and then removing one of them 2x. The bug is that the other value is removed as well. Bug OISF#7828 --> https://redmine.openinfosecfoundation.org/issues/7828 Signed-off-by: Charlie Vigue <charlie.vigue@openvpn.com>
Since userguide/conf.py uses the deprecated get_html_theme_path(), sphinx emits a warning which breaks the build as warnings are treated as errors. Issue: 7859
Ticket: 7843
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13755 +/- ##
===========================================
+ Coverage 77.16% 83.72% +6.55%
===========================================
Files 945 1011 +66
Lines 172228 275068 +102840
===========================================
+ Hits 132906 230309 +97403
- Misses 39322 44759 +5437
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jufajardini
approved these changes
Aug 27, 2025
jufajardini
left a comment
jufajardini
left a comment
Contributor
There was a problem hiding this comment.
- Checks pass (except codeql, for API limits)
- Commits and line changes consistent with original, approved PRs
|
Information: QA ran without warnings. Pipeline = 27250 |
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2626