schema: add descriptions for flow stats counters - v3#13758
Closed
jufajardini wants to merge 2 commits into
Closed
schema: add descriptions for flow stats counters - v3#13758jufajardini wants to merge 2 commits into
jufajardini wants to merge 2 commits into
Conversation
For existing descriptions that weren't like that, yet.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13758 +/- ##
===========================================
+ Coverage 77.16% 83.71% +6.54%
===========================================
Files 945 1011 +66
Lines 172228 275066 +102838
===========================================
+ Hits 132906 230273 +97367
- Misses 39322 44793 +5471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 27259 |
victorjulien
requested changes
Aug 28, 2025
| "local_bypassed": { | ||
| "type": "integer" | ||
| "type": "integer", | ||
| "description": "Number of flows bypassed by Suricata at the time of flow end" |
Member
There was a problem hiding this comment.
bypassed internally?
"at the time of the flow end" is a bit unclear I think. Is the bypass done at the end of the flow, or are we counting at the flow end? (the latter is correct)
Contributor
Author
|
followed by #13765 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task #7794
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7794
Previous PR #13753
Describe changes: