stream: remove incorrect defensive check#13762
Closed
inashivb wants to merge 1 commit into
Closed
Conversation
As a part of the commit d096b98 a defensive check was added stating that the stream must have EOF flag set if it is in TCP_CLOSING state or above. However, this led to a false positive reported by oss-fuzz whose analysis showed that this does not hold true for TCP_CLOSING state. It does hold true only for TCP_CLOSED and if pkt has PKT_PSEUDO_STREAM_END set. TCP_CLOSING state correspond to an established flow hence the correct course of action is to remove the assertion. Bug 7636 Co-authored-by: Philippe Antoine <pantoine@oisf.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13762 +/- ##
==========================================
- Coverage 83.72% 83.71% -0.02%
==========================================
Files 1011 1011
Lines 275068 275067 -1
==========================================
- Hits 230309 230274 -35
- Misses 44759 44793 +34
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 27260 |
catenacyber
approved these changes
Aug 28, 2025
catenacyber
left a comment
catenacyber
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
commit message :
and if pkt has PKT_PSEUDO_STREAM_END should be or if packet
Member
Author
Very right. Please check v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7636