Skip to content

output/alert-debug: do not return on app-layer#13768

Closed
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:alert-debug-log-applayer-4178-v1
Closed

output/alert-debug: do not return on app-layer#13768
catenacyber wants to merge 1 commit into
OISF:masterfrom
catenacyber:alert-debug-log-applayer-4178-v1

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4178

Describe changes:

  • output/alert-debug: really write data for app-layer alerts

just continue, so that we call aft->file_ctx->Write

Ticket: 4178
@catenacyber catenacyber force-pushed the alert-debug-log-applayer-4178-v1 branch from 746212b to 1669af0 Compare August 29, 2025 11:23
@catenacyber

Copy link
Copy Markdown
Contributor Author

cc @norg just a quick fix, no SV test but tested with pcap+rule in the ticket with suricata.yaml having - alert-debug: enabled: yes

@codecov

codecov Bot commented Aug 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.71%. Comparing base (2a17ab6) to head (1669af0).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13768      +/-   ##
==========================================
- Coverage   83.72%   83.71%   -0.01%     
==========================================
  Files        1011     1011              
  Lines      275068   275068              
==========================================
- Hits       230309   230285      -24     
- Misses      44759    44783      +24     
Flag Coverage Δ
fuzzcorpus 62.98% <0.00%> (+0.03%) ⬆️
livemode 19.00% <0.00%> (-0.01%) ⬇️
pcap 44.72% <0.00%> (-0.02%) ⬇️
suricata-verify 65.06% <100.00%> (-0.01%) ⬇️
unittests 59.18% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victorjulien victorjulien added this to the 8.0 milestone Aug 29, 2025
@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 648 626 96.6%

Pipeline = 27289

@victorjulien

Copy link
Copy Markdown
Member

Merged in #13772, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants