Multibuf listkw 7571 v2.1#13777
Closed
catenacyber wants to merge 16 commits into
Closed
Conversation
Ticket: 7867
Ticket: 7571
And use DETECT_DECODE_EVENT directly
to be later able to store information about keywords being about integers
Makes it a generic u32 on the way Unit tests are covered by SV tests
to be able to use it outside of ldap
And make ldap use them
And make ldap use it
and make ldap use it
as we do not pop
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13777 +/- ##
==========================================
- Coverage 83.72% 83.71% -0.01%
==========================================
Files 1011 1010 -1
Lines 275117 275152 +35
==========================================
+ Hits 230328 230349 +21
- Misses 44789 44803 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 27300 |
Contributor
Author
|
So, looking at PR splitting, we have
So, all PRs for 8 are ready |
Contributor
Author
|
Cleaner in #13782 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7571
https://redmine.openinfosecfoundation.org/issues/7480
Reuses #13750 + #13752
Describe changes:
And more to come...
#13681 rebased after some merges
TODO (after merge of #13752 ?) :