Skip to content

Multibuf listkw 7571 v2.1#13777

Closed
catenacyber wants to merge 16 commits into
OISF:masterfrom
catenacyber:multibuf-listkw-7571-v2.1
Closed

Multibuf listkw 7571 v2.1#13777
catenacyber wants to merge 16 commits into
OISF:masterfrom
catenacyber:multibuf-listkw-7571-v2.1

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7571
https://redmine.openinfosecfoundation.org/issues/7480

Reuses #13750 + #13752

Describe changes:

  • list-keywords command line options shows multi-buffers
  • list-keywords command line options shows integer keywords
  • detect/krb5: move krb5_msg_type to rust and makes it a generic u32 on the way
  • dns/detect: rrtype can now use index

And more to come...

#13681 rebased after some merges

TODO (after merge of #13752 ?) :

  • check CI
  • continue work (count keyword...)
  • split + create the appropriate tickets and SV tests

@codecov

codecov Bot commented Aug 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.61610% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.71%. Comparing base (be605ba) to head (5bd4242).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13777      +/-   ##
==========================================
- Coverage   83.72%   83.71%   -0.01%     
==========================================
  Files        1011     1010       -1     
  Lines      275117   275152      +35     
==========================================
+ Hits       230328   230349      +21     
- Misses      44789    44803      +14     
Flag Coverage Δ
fuzzcorpus 62.97% <79.56%> (-0.01%) ⬇️
livemode 19.02% <52.01%> (+0.02%) ⬆️
pcap 44.70% <53.56%> (+<0.01%) ⬆️
suricata-verify 65.10% <86.56%> (+<0.01%) ⬆️
unittests 59.16% <52.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 648 626 96.6%

Pipeline = 27300

@catenacyber

Copy link
Copy Markdown
Contributor Author

So, looking at PR splitting, we have

So, all PRs for 8 are ready

@catenacyber

Copy link
Copy Markdown
Contributor Author

Cleaner in #13782

@catenacyber catenacyber closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants