Xdp tunnel 7674 v15.1#15434
Closed
catenacyber wants to merge 4 commits into
Closed
Conversation
for SV to run tests based on the presence of this feature
Closed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15434 +/- ##
==========================================
- Coverage 82.67% 82.65% -0.03%
==========================================
Files 996 996
Lines 271659 271638 -21
==========================================
- Hits 224601 224527 -74
- Misses 47058 47111 +53
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 31656 |
| fhk.vlan_id[1] = p->vlan_id[1] & g_vlan_mask; | ||
| fhk.vlan_id[2] = p->vlan_id[2] & g_vlan_mask; | ||
|
|
||
| FlowHashIp6Fill(&fhk, p); |
Member
There was a problem hiding this comment.
this looks like it does more than factorize: it adds livedev logic where it previously didn't exist. That requires a separate commit including some thoughts on what it means for this case.
Contributor
Author
There was a problem hiding this comment.
Indeed 7e725c6 was incomplete and forgot FlowGetIpPairProtoHash
victorjulien
requested changes
May 22, 2026
victorjulien
left a comment
victorjulien
left a comment
Member
There was a problem hiding this comment.
See inline. Looks good otherwise.
Closed
Contributor
Author
|
Replaced by #15446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7674 preliminary work
Describe changes:
Easy part of #15415