Cleanups/v6#15734
Open
victorjulien wants to merge 12 commits into
Open
Conversation
Rename progress vars.
Don't allow trailing :
It used the alstate name where it meant tx.
Fixes: 833a738 ("http: fail tx creation if we cannot allocate user data")
Since pstate can't be NULL, remove the conditional logic.
In almost every case, if there is a alstate there is also a pstate. So remove the conditional pstate handling, and replace it by unconditionally using the pointer. Add debug validation to make sure the assumption is and stays correct. Explicitly handle the one exception in AppLayerParserParse, which follows an error before the pstate is allocated, or when pstate allocation itself fails.
Closed
|
WARNING:
Pipeline = 32264 |
jasonish
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc cleanups.
Replaces #15725.