Skip to content

Detect integers allmulti 7929 v9.4#15736

Closed
catenacyber wants to merge 10 commits into
OISF:mainfrom
catenacyber:detect-integers-allmulti-7929-v9.4
Closed

Detect integers allmulti 7929 v9.4#15736
catenacyber wants to merge 10 commits into
OISF:mainfrom
catenacyber:detect-integers-allmulti-7929-v9.4

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7929

Describe changes:

  • remove wrongly flagged SIGMATCH_INFO_MULTI_UINT for krb5_msg_type
  • make enip keywords support multi-integer options
  • remove flags SIGMATCH_INFO_MULTI_UINT where we do not implement it (yet ?)

#15711 with needed rebase

Ticket: 7929

One commit as they share the same code
Ticket: 7929

There is only one msg_type by tx
Ticket: 7929

As both syntaxes share comma as delimiter
So, that if a keyword advertises uint16, it can indeed parse
a uint16 and is not just a uint8
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.94%. Comparing base (09f0851) to head (f634ab0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15736      +/-   ##
==========================================
- Coverage   82.96%   82.94%   -0.03%     
==========================================
  Files        1003     1003              
  Lines      275031   275053      +22     
==========================================
- Hits       228192   228150      -42     
- Misses      46839    46903      +64     
Flag Coverage Δ
fuzzcorpus 61.46% <79.66%> (-0.01%) ⬇️
livemode 18.34% <13.55%> (-0.04%) ⬇️
netns 22.70% <13.55%> (-0.05%) ⬇️
pcap 45.30% <13.55%> (-0.10%) ⬇️
suricata-verify 66.91% <86.44%> (-0.04%) ⬇️
unittests 58.44% <13.55%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.ftp_data 604 672 111.26%
.app_layer.error.ftp.parser 17 0 -

Pipeline = 32269

@victorjulien victorjulien modified the milestones: 8.0, 9.0 Jun 26, 2026
@victorjulien

Copy link
Copy Markdown
Member

Merged in #15740, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants