Skip to content

websocket: implement over HTTP2#15737

Draft
catenacyber wants to merge 3 commits into
OISF:mainfrom
catenacyber:websocket-h2-6729-v2
Draft

websocket: implement over HTTP2#15737
catenacyber wants to merge 3 commits into
OISF:mainfrom
catenacyber:websocket-h2-6729-v2

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6729

Describe changes:

  • draft websocket over http2

TODOs:

  • Agree on the design and output
  • SV test
  • doc update
  • commit segmentation and messages

Tested so far with
suricata -c suricata.yaml -k none -r wss_h2.pcap -S ../suricata-verify/tests/websocket/test.rules -l log

#15675 with rebase, squash, and some review nits implemented

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.08333% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.93%. Comparing base (09f0851) to head (c42e568).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15737      +/-   ##
==========================================
- Coverage   82.96%   82.93%   -0.04%     
==========================================
  Files        1003     1003              
  Lines      275031   275093      +62     
==========================================
- Hits       228192   228137      -55     
- Misses      46839    46956     +117     
Flag Coverage Δ
fuzzcorpus 61.46% <52.08%> (-0.02%) ⬇️
livemode 18.34% <0.00%> (-0.04%) ⬇️
netns 22.72% <1.04%> (-0.03%) ⬇️
pcap 45.35% <50.00%> (-0.04%) ⬇️
suricata-verify 66.89% <52.08%> (-0.06%) ⬇️
unittests 58.44% <5.20%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.ftp_data 604 677 112.09%
.app_layer.error.ftp.parser 17 0 -

Pipeline = 32275

1 similar comment
@suricata-qa

Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.ftp_data 604 677 112.09%
.app_layer.error.ftp.parser 17 0 -

Pipeline = 32275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants