-
Notifications
You must be signed in to change notification settings - Fork 236
Add QEMU multi-arch simulation, Bootgen for AMD Versal Gen 2 #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akshay-Belsare
wants to merge
5
commits into
OP-TEE:master
Choose a base branch
from
Xilinx:amd_versal2_qemu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
25c1398
versal2: add Bootgen build support
amey-raghatate 0be053e
versal2: add QEMU build support
amey-raghatate 46fca6a
versal2: add bootgen.bif and platform config binaries for AMD Versal …
amey-raghatate 4a73f93
versal2: add bootimage target and QEMU run targets for multi-arch sim…
amey-raghatate 0dfe2bb
[REVIEW] Remove redundant existence checks
amey-raghatate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| the_ROM_image: | ||
| { | ||
| image { | ||
| { type=bootimage, file=platconfig.pdi } | ||
| { type=bootloader, file=platconfig.elf } | ||
| } | ||
| image { | ||
| id = 0x1c000000, name=apu_ss | ||
| { type=raw, load=0x1000000, file=versal2-vek385-revA.dtb } | ||
| { core=a78-0, cluster=0, exception_level = el-3, trustzone, file=bl31.elf } | ||
| { core=a78-0, cluster=0, exception_level = el-1, trustzone, load=0x1800000, file=tee-raw.bin } | ||
| { core=a78-0, cluster=0, exception_level = el-2, file=u-boot.elf } | ||
| } | ||
| } |
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other
run-onlytarget infvp.mk,qemu.mk, andqemu_v8.mk, doesn't depend on anything.Since this
run-onlytarget doesn't even do anything, only depend on stuff, how about removing it to avoid confusion?By the way, if
run-onlyis executed with-j<something>,run-qemu-directmight execute beforebootimageis done.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll keep run-only as a standalone target rather than removing it, similar to how it's done upstream. Instead of listing bootimage run-qemu-direct as prerequisites, run-only would do an explicit existence check for each required artifact (TF-A, OP-TEE, U-Boot, DTBs, bootgen, QEMU binaries, kernel Image, rootfs) before invoking the run step directly.
Let us know if this approach works, or if you'd prefer something different — will send the updated patch once confirmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that works.