feat(comment): optionally disable comment#544
feat(comment): optionally disable comment#544FalcoSuessgott wants to merge 1 commit intoOP5dev:mainfrom
Conversation
|
alternatively, we could update |
|
Can you show how you tried it with the normal commenting enabled in your matrix job? Or is the example yaml above already the one with the issue? We are using the action in pretty much every repository with matrix and have no issues at all. |
No the example above is from the approach introduced in this PR (wait for all matrix jobs to finish and then post the plans in separate comments). IIRC I noticed that this GHA would overwrite existing/previous comments (so that one matrix job would overwrite the plan comment of another matrix job), so I wasn't able to see all plans from my matrix jobs. But if you got it work, then there might have been another problem on my side .. Ive migrated to Atlantis, so can't investigate further. Regardless, perhaps this PR still makes sense for some custom setups. |
This action currently attempts to overwrite / recreate any previous comments. While this approach is useful for most setups, it leads to race conditions when this actions is being used in a matrix - where one job overwrites the comment of a previous job.
This PR introduces a new boolean argument
post-commentthat if disabled, skips posting the TF diff comment.Users can then instead use the output of the action and implement their own commenting logic:
This approach could also be used to allow posting all diffs in one comment (#535):
Example:
result: