feat: add preStop lifecycle hook for replication mode#1694
Open
peins94 wants to merge 2 commits intoOT-CONTAINER-KIT:mainfrom
Open
feat: add preStop lifecycle hook for replication mode#1694peins94 wants to merge 2 commits intoOT-CONTAINER-KIT:mainfrom
peins94 wants to merge 2 commits intoOT-CONTAINER-KIT:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replication mode pods currently have no preStop lifecycle hook, unlike cluster mode.
When a master pod is terminated during a rolling update or node drain, clients experience
downtime until Sentinel detects the failure and triggers a failover (up to
down-after-milliseconds).This adds a preStop hook for the
replicationrole following the same pattern as the existingcluster mode hook in
generateClusterPreStop. The hook:INFO replicationSENTINEL FAILOVER mymasterReplica pods skip the hook entirely.
Type of change
Checklist
Additional Context
In production we observed that every rolling restart of a RedisReplication StatefulSet causes
client downtime because the master pod is killed without failover. This is particularly
impactful for large datasets where replica startup takes 30-40 minutes, as Sentinel may
trigger unnecessary full resyncs while the topology is unstable.