fix: pass sentinel config env vars for embedded sentinel in RedisReplication#1695
Open
peins94 wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Open
fix: pass sentinel config env vars for embedded sentinel in RedisReplication#1695peins94 wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
peins94 wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Conversation
…or embedded sentinel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The embedded Sentinel in RedisReplication does not pass through several SentinelConfig
fields as environment variables, unlike the standalone RedisSentinel controller. This means
downAfterMilliseconds,failoverTimeout,parallelSyncs,resolveHostnames, andannounceHostnamesare all ignored for embedded Sentinel deployments despite beingdefined in the CRD.
Additionally, when
announceHostnamesis enabled, Redis replication pods need to setreplica-announce-ipto their FQDN so that Sentinel tracks stable DNS names insteadof ephemeral pod IPs. Without this, pod restarts cause Sentinel to cache stale IPs,
leading to split-brain scenarios and failed failovers.
This PR:
buildSentinelEnvfor embedded SentinelANNOUNCE_HOSTNAME=yesenv var on Redis containers when announceHostnames is enabledreplica-announce-ipto the pod FQDN in the Redis bootstrap configType of change
Checklist
Additional Context
In production, every pod restart in a RedisReplication cluster causes Sentinel to lose
track of replicas because it caches pod IPs that change on restart. This leads to
split-brain (all pods becoming master) and hours-long full resyncs. Enabling
resolveHostnames/announceHostnamesvia the CRD has no effect because the embeddedSentinel ignores these fields.