fix: omit empty tls-ca-cert-file to prevent fatal config error (#1715)#1716
Open
fahrimert wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Open
fix: omit empty tls-ca-cert-file to prevent fatal config error (#1715)#1716fahrimert wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
fahrimert wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
=======================================
Coverage ? 30.12%
=======================================
Files ? 83
Lines ? 6726
Branches ? 0
=======================================
Hits ? 2026
Misses ? 4504
Partials ? 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a fatal configuration error that occurs when a Redis cluster is deployed with TLS but without a provided CA certificate (ca.crt omitted from the Secret).
In v0.24.0, if the CA cert environment variable is empty, the operator writes tls-ca-cert-file "" into the generated redis.conf. This causes the Redis configuration parser to fail with a wrong number of arguments fatal error, crashing the pod.
Changes made:
Fixes #1715
Type of change
Checklist
Additional Context
I successfully reproduced the issue locally on a K3s cluster. I verified the root cause and ensured that this logical fix prevents the empty argument from being written to the configuration file, allowing the Redis pods to start correctly without crashing into a CrashLoopBackOff state.