fix: skip unprobeable pods so failover convergence doesn't stall for minutes - ha split-brain and self-recovery#1728
Open
mvasilenko wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Conversation
mvasilenko
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
…minutes Signed-off-by: Michael Vasilenko <mvasilenko@gmail.com>
mvasilenko
force-pushed
the
fix/redis-operator-skip-unprobeable-pods
branch
from
b3ca756 to
2e09e54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1712 (Sina Sadeghi).
GetRedisNodesByRoleskips Pending/non-Ready/no-PodIP pods instead of returning error on first TCP timeoutVerified on k3d (1 server + 3 agents): node-failure outage reduced from 323s/no-recovery (v0.24.0 stock) to ~39s with
this fix.
Fixes #1711 / #1719