fix(chart): make minAvailable and maxUnavailable optional in redis-replication chart#1732
Open
SvenMark wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Open
fix(chart): make minAvailable and maxUnavailable optional in redis-replication chart#1732SvenMark wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
SvenMark wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Conversation
…plication chart The poddisruptionbudget specification states that either minAvailable or maxUnavailable should be specified. Signed-off-by: SvenMark <22452621+SvenMark@users.noreply.github.com>
SvenMark
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
=======================================
Coverage ? 30.25%
=======================================
Files ? 84
Lines ? 6752
Branches ? 0
=======================================
Hits ? 2043
Misses ? 4517
Partials ? 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The poddisruptionbudget specification states that either
minAvailableormaxUnavailableshould be set.When using server-side apply we get an error that
maxUnavailableis set even though it is 'null' in the chart's values:The provided change makes the
minAvailableormaxUnavailablevalues optional. Either one of them could be set, but not both.Type of change
Checklist
Additional Context