fix(charts/redis-operator): use dynamic serviceDNSDomain in cert-manager#1744
Closed
Marco-Valle wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Closed
fix(charts/redis-operator): use dynamic serviceDNSDomain in cert-manager#1744Marco-Valle wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Marco-Valle wants to merge 1 commit intoOT-CONTAINER-KIT:mainfrom
Conversation
Marco-Valle
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
Marco-Valle
force-pushed
the
main
branch
2 times, most recently
from
e0f0346 to
7891884
Compare
The Certificate template in charts/redis-operator was hardcoded to use '.cluster.local' for DNS names. This caused TLS handshake failures in clusters configured with a custom serviceDNSDomain. This change replaces the hardcoded suffix with the .Values.redisOperator.serviceDNSDomain variable to ensure SANs match the actual cluster environment. Signed-off-by: Marco Valle <marco.valle@tosec.it>
Author
|
I see PR #1752 covers both the certificate and the webhook configuration, including a default value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue in the
redis-operatorHelm chart where theCertificateresource SANs (Subject Alternative Names) were hardcoded to use the.cluster.localdomain suffix.When a cluster is configured with a custom
serviceDNSDomain(e.g.,custom.domain), the generated certificate fails to match the actual service identity, as the SANs do not reflect the environment's DNS configuration.Fixes #1743
Type of change
Checklist
Additional Context
To verify the fix, the chart was deployed with a custom domain configuration: