docs: correct update-rollout and air-gap FAQ answers - #206
Merged
Conversation
Updates reach the cluster by bumping the pinned release tag (targetRevision) via bin/update-kubeaid-argocd-app.sh, not by ArgoCD noticing a mirror merge. Fix upstream branch name (master, not main) and fetch/push tags so the pinned tags exist in the mirror. Air-gap: image references are rewritten to your own Harbor registry by the harbor-proxy-cache-mutate Kyverno policy at admission time; drop the stale per-chart image-override TODO. Signed-off-by: Ashish Jaiswal <ashish@obmondo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two FAQ answers documented the wrong mechanism:
How do updates reach my cluster? claimed ArgoCD notices a mirror merge and marks apps OutOfSync. In reality every Application pins the KubeAid repo to a release tag (
targetRevision), so a mirror merge changes nothing on the cluster — rollout happens by bumping the pinned tag withbin/update-kubeaid-argocd-app.sh -c <cluster> -r <tag>. Also fixed the upstream branch name (master, notmain) here and in Post-Configuration Step 6, and made the manual-update commands fetch/push--tagsso the pinned tags actually exist in the mirror.Can KubeAid run air-gapped? claimed per-chart image repointing is an open TODO. The kyverno chart ships the
harbor-proxy-cache-mutateClusterPolicy, which rewrites docker.io (and optionally ghcr.io / registry.k8s.io) image references to your own Harbor registry at admission time — no per-chart overrides. Same stale TODO dropped from features-technical-details.md; a fully disconnected install stays on the roadmap.