Change Conditions to be RPG-Specific - #328
Open
jayden-hunter wants to merge 1 commit into
Open
Conversation
Author
|
Noting that this might conflict with #323, since I added a new attribute to RpgSystem. Happy to fix this when/if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add support for conditions to be Rpg-specific. I.e. If the system is set as Pf2e, then the Pf2e conditions will be loaded.
Changes Proposed
Add Pf2eConditions, and restructure the conditions so that they are linked to the RpgSystem.
Related Issues
#276
Checklist
Additional Notes