Difficulty bar labels - #338
Open
Trantion897 wants to merge 4 commits into
Open
Conversation
* Remove meter border * Move notches to touch meter * Use relative sizes instead of pixels * Align last notch with end of meter * Reduce font size to x-small * Remove development notes
…x options The text width varies if the difficulty changes, which is not ideal, but it seems OK for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Make the difficulty bar clearer
Changes Proposed
I find it difficult to read the encounter difficulty bar at a glance: the difficulty label of the current encounter isn't clear without mousing over the meter
Related Issues
Fixes #Issue_Number
Checklist
Screenshots (if applicable)
Additional Notes
Potential improvements
The label to the right of the meter changes in size depending on the length of the word, so it will change if you alter encounter difficulty. This could be fixed by setting the width at startup to fit the longest difficulty name, but it might be more trouble than it's worth.
The HTML meter bar can only show 3 colours. It would be nice to have different colours for each difficulty level (up to a point: the colours should be manually chosen to go from green -> yellow -> red). But that would need more JS to override the meter colours.