Skip to content

Add section plot#248

Open
tillmrtz wants to merge 7 commits into
mainfrom
tillmrtz/issue228
Open

Add section plot#248
tillmrtz wants to merge 7 commits into
mainfrom
tillmrtz/issue228

Conversation

@tillmrtz

Copy link
Copy Markdown
Collaborator

Creating new Pull request, since I accidentally created one only for my fork

@tillmrtz tillmrtz self-assigned this Jun 17, 2025
@tillmrtz tillmrtz linked an issue Jun 17, 2025 that may be closed by this pull request
@tillmrtz

Copy link
Copy Markdown
Collaborator Author

The section plot does takes several arguments, such as all variables that should be plotted, the vertical resolution in meters, start and end profiles to plot and also a possible dataframe containing the mld information: plot_section(ds, vars=['PSAL', 'TEMP', 'DENSITY'], v_res=1, start=None, end=None, mld_df = None). In addition to the x-axis representing the profile numbers, a time axis is plotted below.

image

@MOchiara

Copy link
Copy Markdown
Member

Looks good to me! The segmentation errors you are getting is something I think Callum is working on

@callumrollo callumrollo reopened this Jun 10, 2026
@callumrollo

Copy link
Copy Markdown
Member

ok, so it took me almost a year (sorry!) but I did fix those segfaults in the tests.

Looks pretty good to me! I don't think we want the conda lock-file env.yml though? The addition of cmocean to the requirements files that you made should suffice

@tillmrtz tillmrtz requested a review from callumrollo July 3, 2026 07:53
@tillmrtz

tillmrtz commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Locally most tests ran okay, somehow a RunTime Error for the test_plots script now.

Also, the test_mission_summary script produces problems locally. Seems to be okay when trying to merge here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add section plot

3 participants