ci: pin MSSQL image to digest and disable testcontainers ryuk#218
Draft
IsaacCalligeros95 wants to merge 1 commit into
Draft
ci: pin MSSQL image to digest and disable testcontainers ryuk#218IsaacCalligeros95 wants to merge 1 commit into
IsaacCalligeros95 wants to merge 1 commit into
Conversation
Two small reliability fixes for the integration test workflow: - Pin the MSSQL image to an immutable digest and pass OCTO_MSSQLTAG so the test framework starts the same image the workflow pre-pulls. The framework defaults to no tag (:latest), so the existing pre-pull of :2019-latest warmed an image the test never used. A digest pull does not reliably create the plain tag on all Docker engines, so it is applied explicitly with docker tag. - Disable the testcontainers reaper (ryuk). It was intermittently failing container setup when it could not pull its image from Docker Hub (registry-1.docker.io: context deadline exceeded). The framework terminates its own containers and CI runs on ephemeral runners, so the reaper adds no value and only introduces a flaky Docker Hub dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small reliability fixes for the integration test workflow:
Pin the MSSQL image to an immutable digest and pass OCTO_MSSQLTAG so the test framework starts the same image the workflow pre-pulls. The framework defaults to no tag (:latest), so the existing pre-pull of :2019-latest warmed an image the test never used. A digest pull does not reliably create the plain tag on all Docker engines, so it is applied explicitly with docker tag.
Disable the testcontainers reaper (ryuk). It was intermittently failing container setup when it could not pull its image from Docker Hub (registry-1.docker.io: context deadline exceeded). The framework terminates its own containers and CI runs on ephemeral runners, so the reaper adds no value and only introduces a flaky Docker Hub dependency.