Add support for GitURL and Dockerfile in Execution Container Images#234
Merged
Conversation
mcasperson
marked this pull request as ready for review
July 21, 2026 21:02
mcasperson
enabled auto-merge (squash)
July 21, 2026 21:02
…ssStepActionContainerModel
hnrkndrssn
approved these changes
Jul 21, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds Terraform surface area for Octopus “execution container image” fields by exposing git_url and dockerfile alongside existing feed_id/image, across both the legacy SDKv2 schemas and the newer Plugin Framework resources.
Changes:
- Extend the SDKv2
DeploymentActionContainerexpand/flatten + schema to includegit_urlanddockerfile, with a unit test update. - Extend Framework process step container schema/model and mapping logic to round-trip
git_url/dockerfile(including updated mapping tests). - Bump
github.com/OctopusDeploy/go-octopusdeploy/v2dependency and update generated docs to include the new attributes.
Reviewed changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| octopusdeploy/schema_deployment_action_container.go | Adds git_url/dockerfile to SDKv2 container expand/flatten and schema. |
| octopusdeploy/schema_deployment_action_container_test.go | Updates unit test coverage for the SDKv2 container expansion. |
| octopusdeploy_framework/schemas/process_step.go | Adds git_url/dockerfile to Framework container model + schema defaults. |
| octopusdeploy_framework/resource_process_templated_step.go | Passes git_url/dockerfile into container mapping when building API model. |
| octopusdeploy_framework/resource_process_templated_child_step.go | Passes git_url/dockerfile into container mapping when building API model. |
| octopusdeploy_framework/resource_process_step.go | Maps git_url/dockerfile to/from state for process steps. |
| octopusdeploy_framework/resource_process_step_mapping_test.go | Updates mapping tests for the expanded container model (one initialization needs adjustment). |
| octopusdeploy_framework/resource_process_child_step.go | Passes git_url/dockerfile into container mapping when building API model. |
| octopusdeploy_framework/resource_process_child_step_mapping_test.go | Updates mapping tests for child steps with the expanded container model. |
| go.mod | Bumps go-octopusdeploy/v2 version to a release that supports the new container fields. |
| go.sum | Updates checksums for the bumped go-octopusdeploy/v2 dependency. |
| docs/resources/ssh_connection_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/process_templated_step.md | Documents new container fields in resource docs (with descriptions). |
| docs/resources/process_templated_child_step.md | Documents new container fields in resource docs (with descriptions). |
| docs/resources/process_step.md | Documents new container fields in resource docs (with descriptions). |
| docs/resources/process_child_step.md | Documents new container fields in resource docs (with descriptions). |
| docs/resources/polling_tentacle_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/offline_package_drop_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/kubernetes_cluster_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/cloud_region_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/azure_web_app_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/azure_service_fabric_cluster_deployment_target.md | Documents new container fields in resource docs. |
| docs/resources/azure_cloud_service_deployment_target.md | Documents new container fields in resource docs. |
| docs/data-sources/ssh_connection_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/polling_tentacle_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/offline_package_drop_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/kubernetes_cluster_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/cloud_region_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/azure_web_app_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/azure_service_fabric_cluster_deployment_targets.md | Documents new container fields in data source docs. |
| docs/data-sources/azure_cloud_service_deployment_targets.md | Documents new container fields in data source docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ExcludedEnvironments: types.SetValueMust(types.StringType, []attr.Value{}), | ||
| Channels: types.SetValueMust(types.StringType, []attr.Value{}), | ||
| Container: &schemas.ProcessStepActionContainerModel{FeedID: types.StringValue(""), Image: types.StringValue("")}, | ||
| Container: &schemas.ProcessStepActionContainerModel{FeedID: types.StringValue(""), Image: types.StringValue(""), GitUrl: types.StringValue(""), Dockerfile: types.StringNull()}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the
git_urlanddockerfileproperties on the container images.